Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opcode: add/sub trace integration and ci pipeline #209

Merged
merged 4 commits into from
Sep 14, 2024
Merged

opcode: add/sub trace integration and ci pipeline #209

merged 4 commits into from
Sep 14, 2024

Conversation

hero78119
Copy link
Collaborator

@hero78119 hero78119 commented Sep 11, 2024 •
edited
Loading

  • add/sub assignment from trace
  • add integration test ci pipeline

    it will run riscv_add.rs with end 2 end test

@hero78119 hero78119 force-pushed the feat/addsub_trace_integration branch 3 times, most recently from 7774b8d to 08e3245 Compare September 11, 2024 09:53
@hero78119
Copy link
Collaborator Author

TODO: extend integration test on all implemented opcodes

@hero78119
Copy link
Collaborator Author

cc @chaosma @KimiWu123 @zemse for related to opcode development

@hero78119 hero78119 changed the title add/sub trace integration and ci pipeline opcode: add/sub trace integration and ci pipeline Sep 11, 2024
@hero78119 hero78119 mentioned this pull request Sep 12, 2024
Merged
@hero78119 hero78119 force-pushed the feat/addsub_trace_integration branch from 4069a6a to b74c3b4 Compare September 13, 2024 16:59
@hero78119 hero78119 force-pushed the feat/addsub_trace_integration branch from b74c3b4 to dc2107b Compare September 13, 2024 17:13
@hero78119 hero78119 force-pushed the feat/addsub_trace_integration branch from 34e9d58 to 70cb00f Compare September 14, 2024 01:54
@hero78119 hero78119 merged commit 71b1aa2 into master Sep 14, 2024
6 checks passed
@hero78119 hero78119 deleted the feat/addsub_trace_integration branch September 14, 2024 02:09
hero78119 added a commit that referenced this pull request Sep 30, 2024
@hero78119
opcode: add/sub trace integration and ci pipeline (#209)
d646e95 
- [x] add/sub assignment from trace 
- [x] add integration test ci pipeline
   > it will run `riscv_add.rs` with end 2 end test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunxian-xia kunxian-xia kunxian-xia approved these changes

Assignees
No one assigned
Labels
opcode circuit toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hero78119 @kunxian-xia